Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IV: Fix sorting upcoming subscriptions #3485

Conversation

ChunkyProgrammer
Copy link
Member

Fix sorting upcoming subscriptions

Pull Request Type

  • Bugfix

Related issue

closes #3357

Description

video.published is set to current date/time for upcoming invidious videos so this PR uses video.PremiereTimestamp for sorting instead

Testing

  • Subscribe to multiple channels with upcoming videos
  • Switch to IV api
  • Turn off RSS
  • Go to subscriptions
  • profit?

Example channel to subscribe to:
https://www.youtube.com/channel/UCUKPG1-r4WFyxpyhIuCs86Q

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 3, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 3, 2023 19:27
@PikachuEXE
Copy link
Collaborator

Probably not related to this PR but wanted to report these errors
image
Probably harmless

@FreeTubeBot FreeTubeBot merged commit 9003b82 into FreeTubeApp:development May 6, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 6, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the iv-fix-subscription-upcoming-sorting branch May 6, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: incorrect sorting of upcoming videos on Invidious API
5 participants